From 5611bdb72ffee2bc91c1aa0b5497357ad68128cd Mon Sep 17 00:00:00 2001 From: Ross McKay Date: Fri, 13 Jan 2023 16:24:47 +1100 Subject: [PATCH 1/2] use the arguments passed to the `auth_cookie_expiration` hook see [the filter hook doco](https://developer.wordpress.org/reference/hooks/auth_cookie_expiration/) for details on this hook fixes #2 --- biscotti.php | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/biscotti.php b/biscotti.php index 3b23232..badc17d 100644 --- a/biscotti.php +++ b/biscotti.php @@ -74,10 +74,15 @@ function biscotti_login_cookie_expiration_form_fields_update( $user_id ) add_action('personal_options_update', 'biscotti_login_cookie_expiration_form_fields_update'); add_action('edit_user_profile_update', 'biscotti_login_cookie_expiration_form_fields_update'); -// Modify the expiration of the logged in user cookie. -function biscotti_login_cookie_expiration_set_auth_cookie( $auth_cookie_data ) +/** + * Modify the expiration of the logged in user cookie. + * @param int $expiration + * @param int $user_id + * @param bool $remember + * @return int + */ +function biscotti_login_cookie_expiration_set_auth_cookie( int $expiration, int $user_id, bool $remember ) { - $user_id = $auth_cookie_data[0]; $expiration_time = get_user_meta($user_id, 'biscotti_login_cookie_expiration', true); if (! empty($expiration_time) ) { @@ -90,9 +95,8 @@ function biscotti_login_cookie_expiration_set_auth_cookie( $auth_cookie_data ) } else { $expiration = ''; // Use default expiration of 14 days. } - $auth_cookie_data[2] = $expiration; } - return $auth_cookie_data; + return $expiration; } // Modify the expiration of the logged in user cookie when a user logs into the site. -- 2.39.5 From c9be806e3313fd34444843e9599fb23071f6ceea Mon Sep 17 00:00:00 2001 From: Ross McKay Date: Fri, 13 Jan 2023 16:31:27 +1100 Subject: [PATCH 2/2] remove strict typing, for older PHP versions --- biscotti.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/biscotti.php b/biscotti.php index badc17d..a422dca 100644 --- a/biscotti.php +++ b/biscotti.php @@ -81,7 +81,7 @@ add_action('edit_user_profile_update', 'biscotti_login_cookie_expiration_form_fi * @param bool $remember * @return int */ -function biscotti_login_cookie_expiration_set_auth_cookie( int $expiration, int $user_id, bool $remember ) +function biscotti_login_cookie_expiration_set_auth_cookie( $expiration, $user_id, $remember ) { $expiration_time = get_user_meta($user_id, 'biscotti_login_cookie_expiration', true); -- 2.39.5